Use punctuation attachment metadata in batch transcripts#113
Open
sudojatin wants to merge 1 commit into
Open
Conversation
Author
|
@dumitrugutu can you review this PR. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Speechmatics Batch JSON includes punctuation as separate
results[]items. These punctuation items can say how they should attach to nearby words usingattaches_to(previous,next,both, ornone) and can also includeis_eos.The gap in the SDK was in
Transcript.transcript_text: it did not useattaches_towhen building the plain text transcript. Instead, it looked at the punctuation character and guessed where spaces should go. That guess was wrong for some punctuation, such as Spanish opening punctuation (¿Hola?) and punctuation that should attach to both sides (and/or).Summary
Test Plan