fix: Fix BigQuery timestamp literal format in SQL unparsing#144
Merged
sgrebnov merged 1 commit intospiceai-52from Mar 20, 2026
Merged
fix: Fix BigQuery timestamp literal format in SQL unparsing#144sgrebnov merged 1 commit intospiceai-52from
sgrebnov merged 1 commit intospiceai-52from
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes BigQuery SQL unparsing for TIMESTAMP values with time zone offsets by ensuring the UTC offset is formatted without a leading space, preventing BigQuery “invalid timestamp” errors during filter pushdown.
Changes:
- Override
Dialect::timestamp_with_tz_to_stringinBigQueryDialect. - Format timestamp-with-TZ strings using chrono’s
%:zto attach the offset directly to the time, with precision based onTimeUnit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ewgenius
approved these changes
Mar 20, 2026
Author
|
Upstream PR: apache#21103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The default
Dialect::timestamp_with_tz_to_stringusesdt.to_string()which produces timestamps with a space before the TimeZone offset:BigQuery rejects this format. Per the BigQuery timestamp docs, the offset must be attached directly to the time:
This causes filter pushdown to fail when unparsing timestamp predicates for BigQuery.
Changes
Override
timestamp_with_tz_to_stringinBigQueryDialectusing chrono's%:zformat specifier, which produces the offset without a leading space.Before (default
dt.to_string()):After (%:z format):
Similar to DuckDB recent fix: apache#17653