Refactor/general code corrections #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a summary of what I did: - I improved the Protobuf handlers (ProtoMessageReader, ProtoMessageWriter) for better error handling and logger usage. - I made adjustments to the TestResource JAX-RS resource to ensure URI correctness, simplified object creation, and proper HTTP status codes. - I streamlined JaxRsConf for simpler component registration. - I enhanced the WebSocket classes (ClientWebsocketTest, TestWebSocket) for better URI handling, error logging, AutoCloseable implementation, and @OnClose/@onerror handlers. - I added equals() and hashCode() methods to the Citizen POJO and its inner Phone class. - I reviewed DemoApplication and found no changes were needed. All changes build successfully.
… a summary of what I did: - I removed the JAX-RS (spring-boot-starter-jersey) dependency and added spring-boot-starter-web. - I deleted JAX-RS specific configuration files (JaxRsConf, MediaTypeExt, ProtoMessageReader, ProtoMessageWriter). - I converted TestResource (JAX-RS) to TestController (Spring MVC @RestController). - I replaced JAX-RS annotations with Spring MVC equivalents. - I updated method signatures, request/response handling to align with Spring MVC. - I ensured Protobuf and JSON media types are correctly specified for production/consumption. - I verified that Spring Boot's auto-configured ProtobufHttpMessageConverter should handle Protobuf messages. - I reviewed WebSocket client interaction within the new controller; existing JSR-356 support via Undertow is expected to work. - I improved WebSocket client resource management in TestController using try-with-resources. The project builds successfully, and the application context loads after these changes.
- Added unit tests for TestController, Citizen POJO, ClientWebsocketTest, and TestWebSocket. - Refactored ClientWebsocketTest to move connection logic out of the constructor for better testability. - Updated TestController to use the refactored ClientWebsocketTest. - Added WebConfig.java to explicitly register ProtobufHttpMessageConverter, resolving Protobuf handling issues in Spring MVC tests. - Fixed various issues in the newly added tests to ensure they pass and accurately reflect expected behavior. All 29 new tests across 4 test classes are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.