Bump Rector to ~2.6.1 and re-run it - #1297
Merged
Merged
Conversation
roxblnfk
approved these changes
Aug 4, 2026
Contributor
Author
|
@roxblnfk ready to merge 👍. Test error on php 8.4 and 8.5 are unrelated and seems needs separate PR. |
1 task
Contributor
Author
|
PHPUnit error on php 8.4 and php 8.5 is handled at PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR bump Rector to ~2.6.1 and apply rector re-run.
Why?
Changed parts:
fix invalid docblock due to allowed directory value in array docblock (manually apply due to rector run apply invalid change to change return type instead), the fix is in the way:
[DeadCode] Skip assert() enforcement that produce NeverType on NarrowWideUnionReturnTypeRector rectorphp/rector-src#8282
add return type on willReturnCallback() that apply
ClosureReturnTypeRector.Checklist
Documentation