Handle failures in either the primary or hedged request#2
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
a10y
reviewed
Jul 17, 2026
| r = f2 => { | ||
| r? | ||
| } | ||
| biased; |
There was a problem hiding this comment.
we want it to be biased b/c we would prefer the primary result ?
There was a problem hiding this comment.
I guess actually it's b/c in our case starvation isn't a concern and we don't want the overhead of fairness
a10y
reviewed
Jul 17, 2026
| } | ||
|
|
||
| #[async_trait] | ||
| impl ObjectStore for FailingHedgeStore { |
There was a problem hiding this comment.
kinda silly how much boiler plate is required
Contributor
Author
There was a problem hiding this comment.
there are crates that help deal with that, IDK if I want to pull them? The alternative is probably having one test-only impl that is fully configurable around failures/errors.
a10y
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.