Skip to content

Commit 58f5957

Browse files
committed
updated test coverage
1 parent a904ef4 commit 58f5957

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

client/src/test/java/io/split/client/SplitClientImplTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1486,6 +1486,7 @@ public void worksAndHasConfigByFlagSetTryKetTreatmentWithKey() {
14861486
assertEquals("on", client.getTreatmentsByFlagSet(randomKey, "set1", new HashMap<>()).get(test));
14871487
assertEquals("{\"size\" : 30}", client.getTreatmentsWithConfigByFlagSet(key, "set1", attributes).get(test).config());
14881488
}
1489+
assertEquals("on", client.getTreatmentsByFlagSet("randomKey", "set1").get(test));
14891490
}
14901491

14911492
@Test
@@ -1899,6 +1900,8 @@ public void testTreatmentsByFlagSet() {
18991900
}
19001901
verify(splitCacheConsumer, times(numKeys)).fetchMany(new ArrayList<>(Arrays.asList(test)));
19011902
verify(TELEMETRY_STORAGE, times(5)).recordLatency(Mockito.anyObject(), Mockito.anyLong());
1903+
getTreatmentResult = client.getTreatmentsByFlagSet("randomKey", "set1");
1904+
assertEquals("on", getTreatmentResult.get(test));
19021905
}
19031906

19041907
@Test
@@ -1980,6 +1983,9 @@ public void testTreatmentsByFlagSets() {
19801983
}
19811984
verify(splitCacheConsumer, times(numKeys)).fetchMany(new ArrayList<>(Arrays.asList(test2, test)));
19821985
verify(TELEMETRY_STORAGE, times(5)).recordLatency(Mockito.anyObject(), Mockito.anyLong());
1986+
getTreatmentResult = client.getTreatmentsByFlagSets("key", Arrays.asList("set1", "set3"));
1987+
assertEquals("on", getTreatmentResult.get(test));
1988+
assertEquals("on", getTreatmentResult.get(test2));
19831989
}
19841990

19851991
@Test
@@ -2030,6 +2036,12 @@ public void treatmentsWorksAndHasConfigFlagSet() {
20302036
assertEquals("control", result.get(test2).treatment());
20312037

20322038
verify(splitCacheConsumer, times(1)).fetchMany(anyList());
2039+
2040+
result = client.getTreatmentsWithConfigByFlagSet("randomKey", "set1");
2041+
assertEquals(2, result.size());
2042+
assertEquals(configurations.get("on"), result.get(test).config());
2043+
assertNull(result.get(test2).config());
2044+
assertEquals("control", result.get(test2).treatment());
20332045
}
20342046

20352047
@Test

0 commit comments

Comments
 (0)