polish

Author: chillaq

client/src/main/java/io/split/client/SplitClientImpl.java

@@ -552,7 +552,7 @@ private String validateProperties(Map<String, Object> properties) {
 
          ImpressionPropertiesValidator.ImpressionPropertiesValidatorResult iPValidatorResult = ImpressionPropertiesValidator.propertiesAreValid(
                     properties);
-         return  new GsonBuilder().create().toJson(iPValidatorResult.getValue()).toString();
+         return  new GsonBuilder().create().toJson(iPValidatorResult.getValue());
     }
 
     private Map<String, SplitResult> getTreatmentsWithConfigInternal(String matchingKey, String bucketingKey, List<String> featureFlagNames,

client/src/main/java/io/split/client/dtos/EvaluationOptions.java

@@ -10,5 +10,5 @@ public EvaluationOptions(Map<String, Object> properties) {
     }
     public Map<String, Object> getProperties() {
         return _properties;
-    };
+    }
 }

client/src/main/java/io/split/client/dtos/KeyImpression.java

@@ -17,8 +17,6 @@ public class KeyImpression {
     /* package private */ static final String FIELD_PREVIOUS_TIME = "pt";
     /* package private */ static final String FIELD_PROPERTIES = "properties";
 
-    public static int MAX_PROPERTIES_LENGTH_BYTES = 32 * 1024;
-
     public transient String feature; // Non-serializable
 
     @SerializedName(FIELD_KEY_NAME)

client/src/main/java/io/split/client/impressions/strategy/ProcessImpressionOptimized.java

@@ -32,16 +32,14 @@ public ProcessImpressionOptimized(boolean listenerEnabled, ImpressionObserver im
     public ImpressionsResult process(List<Impression> impressions) {
         List<Impression> impressionsToQueue = new ArrayList<>();
         for(Impression impression : impressions) {
-            if (impression.properties() != null) {
-                impressionsToQueue.add(impression);
-                continue;
-            }
-            impression = impression.withPreviousTime(_impressionObserver.testAndSet(impression));
-            if(!Objects.isNull(impression.pt()) && impression.pt() != 0){
-                _impressionCounter.inc(impression.split(), impression.time(), 1);
-            }
-            if(shouldntQueueImpression(impression)) {
-                continue;
+            if (impression.properties() == null) {
+                impression = impression.withPreviousTime(_impressionObserver.testAndSet(impression));
+                if (!Objects.isNull(impression.pt()) && impression.pt() != 0) {
+                    _impressionCounter.inc(impression.split(), impression.time(), 1);
+                }
+                if (shouldntQueueImpression(impression)) {
+                    continue;
+                }
             }
             impressionsToQueue.add(impression);
         }

client/src/main/java/io/split/inputValidation/ImpressionPropertiesValidator.java

@@ -3,7 +3,9 @@
 import java.util.Map;
 
 public class ImpressionPropertiesValidator {
-
+    private ImpressionPropertiesValidator() {
+        throw new IllegalStateException("Utility class");
+    }
     public static ImpressionPropertiesValidatorResult propertiesAreValid(Map<String, Object> properties) {
         EventsValidator.EventValidatorResult result = EventsValidator.propertiesAreValid(properties);
         return new ImpressionPropertiesValidatorResult(result.getSuccess(), result.getEventSize(), result.getValue());