Merge branch 'development' into feature/impression-properties

Author: chillaq

CHANGES.txt

@@ -1,3 +1,6 @@
+4.14.1 (XXX XX, XXXX)
+- Prevent polling threads from starting when the SDK calls destroy method.
+
 4.14.0 (Jan 17, 2025)
 - Added support for the new impressions tracking toggle available on feature flags, both respecting the setting and including the new field being returned on SplitView type objects. Read more in our docs.
 - Cleaned unused imports to fix a collision issue.

client/src/main/java/io/split/client/JsonLocalhostSplitChangeFetcher.java

@@ -47,13 +47,13 @@ private SplitChange processSplitChange(SplitChange splitChange, long changeNumbe
             return null;
         }
         String splitJson = splitChange.splits.toString();
-        MessageDigest digest = MessageDigest.getInstance("SHA-1");
+        MessageDigest digest = MessageDigest.getInstance("SHA-256");
         digest.reset();
         digest.update(splitJson.getBytes());
         // calculate the json sha
         byte [] currHash = digest.digest();
         //if sha exist and is equal to before sha, or if till is equal to default till returns the same segmentChange with till equals to storage CN
-        if (Arrays.equals(lastHash, currHash) || splitChangeToProcess.till == -1) {
+        if (java.security.MessageDigest.isEqual(lastHash, currHash) || splitChangeToProcess.till == -1) {
             splitChangeToProcess.till = changeNumber;
         }
         lastHash = currHash;

client/src/main/java/io/split/engine/common/SyncManagerImp.java

@@ -212,6 +212,11 @@ private void startPollingMode() {
                     case STREAMING_DOWN:
                         _log.info("Streaming service temporarily unavailable, working in polling mode.");
                         _pushManager.stopWorkers();
+                        //  if the whole SDK is being shutdown, don't start polling,
+                        //  in case the polling threads are not terminated and a graceful shutdown will fail.
+                        if(_shuttedDown.get()) {
+                            break;
+                        }
                         _synchronizer.startPeriodicFetching();
                         break;
                     case STREAMING_BACKOFF: