-
Notifications
You must be signed in to change notification settings - Fork 23
Updated evaluator #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chillaq
merged 6 commits into
feature/fallback-treatments
from
FME-9876-fallback-evaluator
Sep 8, 2025
Merged
Updated evaluator #598
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5f2084d
Updated evaluator
chillaq 455cf27
Update client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java
chillaq 1f3e613
Update client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java
chillaq 6004e55
Update client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java
chillaq cda0248
Update client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java
chillaq be872d2
added fallback calculator
chillaq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
client/src/main/java/io/split/client/dtos/FallbackTreatmentCalculator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package io.split.client.dtos; | ||
|
|
||
| public interface FallbackTreatmentCalculator | ||
| { | ||
| FallbackTreatment resolve(String flagName, String label); | ||
| } |
40 changes: 40 additions & 0 deletions
40
client/src/main/java/io/split/client/dtos/FallbackTreatmentCalculatorImp.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package io.split.client.dtos; | ||
|
|
||
| import io.split.grammar.Treatments; | ||
|
|
||
| public class FallbackTreatmentCalculatorImp implements FallbackTreatmentCalculator | ||
| { | ||
| private final FallbackTreatmentsConfiguration _fallbackTreatmentsConfiguration; | ||
| private final String labelPrefix = "fallback - "; | ||
|
|
||
| public FallbackTreatmentCalculatorImp(FallbackTreatmentsConfiguration fallbackTreatmentsConfiguration) { | ||
| _fallbackTreatmentsConfiguration = fallbackTreatmentsConfiguration; | ||
| } | ||
|
|
||
| public FallbackTreatment resolve(String flagName, String label) { | ||
| if (_fallbackTreatmentsConfiguration != null) { | ||
| if (_fallbackTreatmentsConfiguration.getByFlagFallbackTreatment() != null | ||
| && _fallbackTreatmentsConfiguration.getByFlagFallbackTreatment().get(flagName) != null) { | ||
| return copyWithLabel(_fallbackTreatmentsConfiguration.getByFlagFallbackTreatment().get(flagName), | ||
| resolveLabel(label)); | ||
| } | ||
| if (_fallbackTreatmentsConfiguration.getGlobalFallbackTreatment() != null) { | ||
| return copyWithLabel(_fallbackTreatmentsConfiguration.getGlobalFallbackTreatment(), | ||
| resolveLabel(label)); | ||
| } | ||
| } | ||
|
|
||
| return new FallbackTreatment(Treatments.CONTROL, null, label); | ||
| } | ||
|
|
||
| private String resolveLabel(String label) { | ||
| if (label == null) { | ||
| return null; | ||
| } | ||
| return labelPrefix + label; | ||
| } | ||
|
|
||
| private FallbackTreatment copyWithLabel(FallbackTreatment fallbackTreatment, String label) { | ||
| return new FallbackTreatment(fallbackTreatment.getTreatment(), fallbackTreatment.getConfig(), label); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.