Add track and evaluation with details #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
requested changes
Sep 3, 2025
src/lib/js-split-provider.ts
Outdated
| flagKey, | ||
| this.transformContext(context) | ||
| ); | ||
| const flagName = details.value.toLowerCase(); |
Contributor
There was a problem hiding this comment.
flagName sounds like the feature flag name, but here the variable refers to the treatment value, right? So flagValue or flagTreatment are more appropriate names.
src/lib/js-split-provider.ts
Outdated
| if (trafficType == null || trafficType === "") | ||
| throw new ParseError("Missing trafficType variable, required to track"); | ||
|
|
||
| let value = 0; |
Contributor
There was a problem hiding this comment.
value should not be 0 by default, but undefined. We should support the default case where the user doesn't want to send a value with the event. For example when calling track without value: client.track(targettingKey, trafficType, trackingEventName);
Contributor
Author
There was a problem hiding this comment.
Agree, but internally the sdk sends 0 if value is undefined, so it will not have major difference
EmilianoSanchez
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.