Skip to content

Conversation

@kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Dec 12, 2025

Depends On

Description

It splits BusConfiguration CR into 2 CRs - Queue and ObjectStorage as per internal documentation.

Key Changes

  • New CRs - Queue and ObjectStorage
  • Validations added to new CRs
  • Updated documentation and Helm charts

Testing and Verification

  • Manual tests
  • Automated tests

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-4358

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2025

Pull Request Test Coverage Report for Build 20365107317

Details

  • 289 of 438 (65.98%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 85.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/objectstorage_controller.go 10 13 76.92%
pkg/splunk/enterprise/types.go 0 4 0.0%
pkg/splunk/enterprise/upgrade.go 0 4 0.0%
pkg/splunk/enterprise/util.go 14 19 73.68%
internal/controller/queue_controller.go 46 52 88.46%
pkg/splunk/enterprise/ingestorcluster.go 73 82 89.02%
pkg/splunk/enterprise/objectstorage.go 31 40 77.5%
pkg/splunk/enterprise/queue.go 31 40 77.5%
internal/controller/indexercluster_controller.go 10 28 35.71%
internal/controller/ingestorcluster_controller.go 10 28 35.71%
Totals Coverage Status
Change from base Build 19886830069: -0.3%
Covered Lines: 11403
Relevant Lines: 13410

💛 - Coveralls

@kasiakoziol kasiakoziol changed the title CSPL-4358 Split BusConfiguration CR into 2 CRs - Bus and LargeMessageStore CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage Dec 23, 2025
@kasiakoziol kasiakoziol marked this pull request as ready for review December 23, 2025 14:20
case "BusConfiguration":
latestBusCR := &enterpriseApi.BusConfiguration{}
err = client.Get(ctx, namespacedName, latestBusCR)
case "Queue":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should take responsibility for updating the queue or object storage, or for adding any controller logic or status updates for them. The only thing we are doing is reading the queue and object storage CRs and using their data as a reference in the ingestor and indexer. I think we should not add any controllers for these 2 specs that is the work for structure storage only when they want to actively manage them.

another point is asking customers for creating these custom resources, i know there is no other option, but I am a bit concerned that we are asking customers to provide a full CR spec.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding controllers, I responded in another thread.

Regarding creating these CR specs, then how do you see this happen in a different way, not provided by the customer? We have no other way to get this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants