Skip to content

feat: migrate integration tests to new Confidence workspace #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicklasl merged 1 commit into from
May 22, 2026
Merged

feat: migrate integration tests to new Confidence workspace #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ jobs:
- name: Run build debug
run: ./gradlew assembleDebug
- name: Run Tests
env:
CONFIDENCE_CLIENT_SECRET: ${{ secrets.CONFIDENCE_CLIENT_SECRET }}
run: ./gradlew :Provider:testDebugUnitTest --no-daemon --stacktrace --info
- name: Run build release
run: ./gradlew assembleRelease
4 changes: 3 additions & 1 deletion Confidence/src/test/java/com/spotify/confidence/ConfidenceIntegrationTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.Context
import com.spotify.confidence.cache.FileDiskStorage
import com.spotify.confidence.client.ResolvedFlag
import org.junit.Assert
import org.junit.Assume
import org.junit.Before
import org.junit.Rule
import org.junit.Test
Expand All @@ -15,7 +16,7 @@ import org.mockito.kotlin.whenever
import java.nio.file.Files
import java.util.UUID

private const val clientSecret = "21wxcxXpU6tKBRFtEFTXYiH7nDqL86Mm"
private val clientSecret = System.getenv("CONFIDENCE_CLIENT_SECRET") ?: ""
private val mockContext: Context = mock()

class ConfidenceIntegrationTests {
Expand All @@ -25,6 +26,7 @@ class ConfidenceIntegrationTests {

@Before
fun setup() {
Assume.assumeTrue("CONFIDENCE_CLIENT_SECRET not set, skipping integration tests", clientSecret.isNotEmpty())
whenever(mockContext.filesDir).thenReturn(Files.createTempDirectory("tmpTests").toFile())
whenever(mockContext.getDir(any(), any())).thenReturn(Files.createTempDirectory("events").toFile())
whenever(mockContext.getSharedPreferences(SHARED_PREFS_NAME, Context.MODE_PRIVATE)).thenReturn(InMemorySharedPreferences())
Expand Down
4 changes: 3 additions & 1 deletion Confidence/src/test/java/com/spotify/confidence/EventSenderIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.advanceUntilIdle
import kotlinx.coroutines.test.runTest
import org.junit.Assert
import org.junit.Assume
import org.junit.Before
import org.junit.Test
import org.mockito.kotlin.any
Expand All @@ -19,7 +20,7 @@ import org.mockito.kotlin.whenever
import java.io.File
import java.nio.file.Files

private const val clientSecret = "WciJVLIEiNnRxV8gaYPZNCFF8vbAXOu6"
private val clientSecret = System.getenv("CONFIDENCE_CLIENT_SECRET") ?: ""
private val mockContext: Context = mock()
private val mockSharedPrefs: SharedPreferences = mock()
private val mockSharedPrefsEdit: SharedPreferences.Editor = mock()
Expand All @@ -32,6 +33,7 @@ class EventSenderIntegrationTest {

@Before
fun setup() {
Assume.assumeTrue("CONFIDENCE_CLIENT_SECRET not set, skipping integration tests", clientSecret.isNotEmpty())
whenever(mockContext.getDir("events", Context.MODE_PRIVATE)).thenReturn(directory)
whenever(mockContext.getSharedPreferences(SHARED_PREFS_NAME, Context.MODE_PRIVATE)).thenReturn(mockSharedPrefs)
whenever(mockSharedPrefs.edit()).thenReturn(mockSharedPrefsEdit)
Expand Down
4 changes: 3 additions & 1 deletion Provider/src/test/java/com/spotify/confidence/openfeature/ProviderIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import org.junit.Assert.assertNotEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Assume
import org.junit.Before
import org.junit.Rule
import org.junit.Test
Expand All @@ -41,7 +42,7 @@ import java.io.File
import java.nio.file.Files
import java.util.UUID

private const val clientSecret = "21wxcxXpU6tKBRFtEFTXYiH7nDqL86Mm"
private val clientSecret = System.getenv("CONFIDENCE_CLIENT_SECRET") ?: ""
private val mockContext: Context = mock()

class ProviderIntegrationTest {
Expand All @@ -53,6 +54,7 @@ class ProviderIntegrationTest {

@Before
fun setup() = runTest(UnconfinedTestDispatcher()) {
Assume.assumeTrue("CONFIDENCE_CLIENT_SECRET not set, skipping integration tests", clientSecret.isNotEmpty())
mockkStatic(Log::class)
every { Log.d(any(), any()) } answers {
println("DEBUG: ${arg<String>(1)}")
Expand Down
Loading