Sqlalchemy 2 fix#3429
Conversation
a6d3f14 to
4bbb851
Compare
…qla>2 is fixed in pyproject
…om CONTRIBUTING.rst
|
I get strange result during testing with the CI. It reports test/contrib/docker_runner_test.py::TestDockerTask::test_fail_job_container as failed but on my local machine the test passes, so it is hard for me to figure out what is wrong... |
|
The docker contrib failure was transient. After rerunning CI, I now see a ruff format error. Please check and address. |
|
From my point of view this PR is ready to be merged. If more work is required one the coverage I would need some directions... |
|
The failing check is CodeCov's patch coverage gate - it requires 50% of the new/changed lines in your PR to be covered by the test suite. This isn't a reflection on the quality of the fix itself. To get this merged, there are two paths:
Either approach works. I've had mixed feelings about the codecov patch check and have almost removed it before; however, it does uncover areas of weaker test coverage in the project. |
dlstadther
left a comment
There was a problem hiding this comment.
Thanks for your persistence here! And sorry for my delays!
Description
As mentioned in the referenced PR luigi with enabled task_history is not compatible with sqlalchemy version >2 as raw sql is now supposed to be supplied with the
text()construct (See https://docs.sqlalchemy.org/en/14/changelog/migration_20.html)I have merged spotify/luigi master into the sqlalchemy_2_fix branch from @pjaol and updated the syntax changes.
Motivation and Context
#3267
Have you tested this? If so, how?
I tested with
tox run -e py310-corelocally.