This repository was archived by the owner on Dec 15, 2021. It is now read-only.
Add conversion of hyphen into underscore before setting STAGING_DATAS…#73
Open
godajaiko21 wants to merge 1 commit intospotify:masterfrom
Open
Add conversion of hyphen into underscore before setting STAGING_DATAS…#73godajaiko21 wants to merge 1 commit intospotify:masterfrom
godajaiko21 wants to merge 1 commit intospotify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request includes a minor bug fix to correctly create staging dataset.
In
com.spotify.spark.bigquery.BigQueryClient, currentlySTAGING_DATASET_IDconfig includesSTAGING_DATASET_LOCATIONstring by default, but if the location includes hyphen(e.g. asia-northeast1), then the dataset-id can't satisfy its naming rule[1] and dataset creation fails.[1]: https://cloud.google.com/bigquery/docs/datasets#dataset-naming
So could you please add the conversion of hyphen into underscore before setting
STAGING_DATASET_ID?Thanks