This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Open
Conversation
spravil
suggested changes
May 17, 2022
Owner
spravil
left a comment
spravil
left a comment
There was a problem hiding this comment.
Thanks for your contribution to the project. There are a few things that need to be addressed before merging:
- Remove the "This is just a fork!" in the README
- Undo the changes to the Installation section in the README
- No modifications to the composer.json
Author
|
Please don´t mind the other files, merge just the first commit. (i am bad at using Github and I didn´t want to commit the readme and composer file). I modified the other two files only on my fork, because I am now using it in a laravel project of mine. I may think of selling my laravel app, so if anyone dove in the source code, I wanted to make clear this dependency isn´t mine. Are you okay with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this repository is discontinued, but I really like it and it should be kept for any newbies searching the internet for something like this. Please merge my pull request, by doing so this code will be able to retrieve all the information Minecraft outputs on its own (without enabling query).