refactor(claude-session): Remove initial prompt in session initialization#23
Closed
ziscloud wants to merge 1 commit intospring-ai-community:mainfrom
Closed
refactor(claude-session): Remove initial prompt in session initialization#23ziscloud wants to merge 1 commit intospring-ai-community:mainfrom
ziscloud wants to merge 1 commit intospring-ai-community:mainfrom
Conversation
…tion - Remove redundant effectivePrompt variable assignment - Directly use initialPrompt instead of creating duplicate variable - Add null check logging for sessions without initial prompt - Maintain same functionality while reducing code complexity - Improve code readability by eliminating unnecessary variable
Contributor
|
Thank you for the cleanup, @ziscloud! Good observation about the unnecessary default prompt. Since this PR was opened, session handling has been rewritten with the new Closing as stale. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default initial prompt will produce an unexpected response and token consuming.