Skip to content

Add ability to add HttpMessageConverters at specific indexes - GH-36043 #36047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haydenrear wants to merge 1 commit into from
+23 −4
Closed

Add ability to add HttpMessageConverters at specific indexes - GH-36043 #36047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ...ng-web/src/main/java/org/springframework/http/converter/DefaultHttpMessageConverters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ private void checkConverterSupports(HttpMessageConverter<?> converter, MediaType
throw new IllegalArgumentException("converter should support '" + mediaType + "'");
}

void addCustomMessageConverter(HttpMessageConverter<?> customConverter) {
void addCustomMessageConverter(int index, HttpMessageConverter<?> customConverter) {
Assert.notNull(customConverter, "'customConverter' must not be null");
this.customConverters.add(customConverter);
this.customConverters.add(index, customConverter);
}

void addMessageConverterConfigurer(Consumer<HttpMessageConverter<?>> configurer) {
Expand Down Expand Up @@ -432,7 +432,13 @@ public ClientBuilder withYamlConverter(HttpMessageConverter<?> yamlConverter) {

@Override
public ClientBuilder addCustomConverter(HttpMessageConverter<?> customConverter) {
addCustomMessageConverter(customConverter);
addCustomConverter(0, customConverter);
return this;
}

@Override
public ClientBuilder addCustomConverter(int index, HttpMessageConverter<?> customConverter) {
addCustomMessageConverter(index, customConverter);
return this;
}

Expand Down Expand Up @@ -529,7 +535,13 @@ public ServerBuilder withYamlConverter(HttpMessageConverter<?> yamlConverter) {

@Override
public ServerBuilder addCustomConverter(HttpMessageConverter<?> customConverter) {
addCustomMessageConverter(customConverter);
addCustomMessageConverter(0, customConverter);
return this;
}

@Override
public ServerBuilder addCustomConverter(int index, HttpMessageConverter<?> customConverter) {
addCustomMessageConverter(0, customConverter);
return this;
}

Expand Down
7 changes: 7 additions & 0 deletions spring-web/src/main/java/org/springframework/http/converter/HttpMessageConverters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ interface Builder<T extends Builder<T>> {
*/
T addCustomConverter(HttpMessageConverter<?> customConverter);


/**
* Add a custom {@code HttpMessageConverter} to the list of converters, at the specified index, pushing all existing message converters forward one.
* @param customConverter the converter instance to add
*/
T addCustomConverter(int index, HttpMessageConverter<?> customConverter);

/**
* Add a consumer for configuring the selected message converters.
* @param configurer the configurer to use
Expand Down