Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
* @author Rob Winch
* @author Vedran Pavic
* @author Eddú Meléndez
* @author Khyojae
* @since 1.1
*/
public class DefaultCookieSerializer implements CookieSerializer {
Expand Down Expand Up @@ -410,6 +411,10 @@ public void setRememberMeRequestAttribute(String rememberMeRequestAttribute) {
* @since 2.1.0
*/
public void setSameSite(String sameSite) {
if (sameSite == null) {
this.sameSite = "Lax";
return;
}
this.sameSite = sameSite;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
* @author Rob Winch
* @author Vedran Pavic
* @author Eddú Meléndez
* @author Khyojae
*/
class DefaultCookieSerializerTests {

Expand Down Expand Up @@ -460,6 +461,22 @@ void writeCookieSetSameSiteNull() {
assertThat(getCookie().getSameSite()).isNull();
}




@Test
void writeCookieShouldUseDefaultSameSiteWhenNotSet() {
DefaultCookieSerializer serializer = new DefaultCookieSerializer();
serializer.setSameSite(null);

MockHttpServletRequest request = new MockHttpServletRequest();
MockHttpServletResponse response = new MockHttpServletResponse();
serializer.writeCookieValue(new CookieValue(request, response, "test-id"));

assertThat(response.getHeader("Set-Cookie")).contains("SameSite=Lax");
}


void setCookieName(String cookieName) {
this.cookieName = cookieName;
this.serializer.setCookieName(cookieName);
Expand Down