Skip to content

bug fix and add non root version#4

Open
hero-intelligent wants to merge 6 commits intospurin:masterfrom
hero-intelligent:non-root
Open

bug fix and add non root version#4
hero-intelligent wants to merge 6 commits intospurin:masterfrom
hero-intelligent:non-root

Conversation

@hero-intelligent
Copy link

Hi.

There is something that you need to do yourself. Build and push another two images to docker hub named spurin/hexo:latest and spurin/hexo:nonroot and edit the README.md in the TODO AND NOTICE part. I've written them in the TODO AND NOTICE in the README.md file.

Earlier I have made a pull request that fix a tiny bug and switch root mode into non-root mode, but I realized some compatible issues, for the working directory has to be changed into a longer one to use non-root mode. Considering that most of the users are server users, especially for those beginners, it is OK and more convenient for them to use root mode directly, because most of their servers have the only root user. And for those server maintainers, compatible issues can cause huge problems or even financial loss, so I just cancelled and kept the root mode.

@hero-intelligent
Copy link
Author

hero-intelligent commented Aug 26, 2023

this is the bug that i have fixed, relevant logs are as follows:

***** Copying .ssh from App directory and setting permissions *****
cp: cannot stat '/app/.ssh': No such file or directory

@hero-intelligent
Copy link
Author

#3 has closed, and this is the final result. Please review my code. Thanks for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant