bug fix and add non root version#4
Open
hero-intelligent wants to merge 6 commits intospurin:masterfrom
Open
Conversation
Author
|
this is the bug that i have fixed, relevant logs are as follows: |
Author
|
#3 has closed, and this is the final result. Please review my code. Thanks for your attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
There is something that you need to do yourself. Build and push another two images to docker hub named
spurin/hexo:latestandspurin/hexo:nonrootand edit the README.md in the TODO AND NOTICE part. I've written them in the TODO AND NOTICE in the README.md file.Earlier I have made a pull request that fix a tiny bug and switch root mode into non-root mode, but I realized some compatible issues, for the working directory has to be changed into a longer one to use non-root mode. Considering that most of the users are server users, especially for those beginners, it is OK and more convenient for them to use root mode directly, because most of their servers have the only root user. And for those server maintainers, compatible issues can cause huge problems or even financial loss, so I just cancelled and kept the root mode.