Skip to content

Fix: GattChannelHandler did not always listen to new binary change events #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfink wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: GattChannelHandler did not always listen to new binary change events #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/sputnikdev/esh/binding/bluetooth/handler/BluetoothHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ public void channelUnlinked(ChannelUID channelUID) {
});
}

public boolean hasChannelHandler(ChannelHandler handler) {
return this.channelHandlers.containsKey(handler);
}

@Override
protected void updateState(String channelID, State state) {
super.updateState(channelID, state);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/sputnikdev/esh/binding/bluetooth/handler/GattChannelHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ private boolean channelRequired(Field field) {
}

private void buildMissingBinaryChannel() {
if (getBinaryChannel() == null) {
if (!handler.hasChannelHandler(this) || getBinaryChannel() == null) {
Channel channel = buildBinaryChannel();
handler.registerChannel(channel.getUID(), this);
handler.updateThingWithChannels(Collections.singletonList(channel));
Expand Down