Ensure that msg['content']['prompt'] is string#136
Closed
PolarNick239 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Ipython supports python2.7 only up to 5.x versions, but requirements.txt uses master version May be it is possible to require |
Contributor
|
The protocol declares that this will be a string, so I think the bug is really on the IPython kernel side, where we should be doing the same casting that stdlib raw_input does. ipython/ipykernel#186 does this. I've opened #137 to address the test dependencies problem. That requirements.txt should have gone away a long time ago. |
Contributor
Author
|
Ok, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #135