Skip to content

Conversation

@danielebriggi
Copy link
Member

No description provided.

@danielebriggi danielebriggi self-assigned this Sep 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the codebase from using the attrs library to Python's built-in dataclasses, removing an external dependency and improving the title extraction logic for documents.

  • Replaces attrs decorators with standard dataclasses throughout the codebase
  • Updates default field initialization to use field(default_factory=...) to avoid mutable default arguments
  • Improves title extraction to require at least one word character in fallback lines
  • Removes attrs dependency from project configuration

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/sqlite_rag/models/document.py Migrates from attrs to dataclasses, fixes mutable defaults, and improves title extraction logic
src/sqlite_rag/models/chunk.py Updates import from attrs to dataclasses
src/sqlite_rag/sqliterag.py Adds .copy() calls to metadata parameters to prevent mutation
pyproject.toml Removes attrs dependency
tests/test_sqlite_rag.py Adds test for document title generation functionality
tests/models/test_document.py Adds test case for title extraction with word requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

chore(dependencies): remove attrs
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/integration/test_engine.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielebriggi danielebriggi merged commit 1e24f17 into main Sep 27, 2025
5 checks passed
@danielebriggi danielebriggi deleted the general-fixes branch September 27, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants