Skip to content

Conversation

@danielebriggi
Copy link
Member

Ticket #8

@danielebriggi danielebriggi requested a review from Copilot October 7, 2025 11:09
@danielebriggi danielebriggi self-assigned this Oct 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for selectively including or excluding files by extension when adding documents, and updates tests accordingly.

  • Introduces only_extensions and exclude_extensions parameters to CLI, SQLiteRag.add, and FileReader APIs.
  • Refactors FileReader.extensions to drop leading dots and enhances filtering logic.
  • Expands test coverage for new filtering behavior.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_sqlite_rag.py Adds tests for add() with only/exclude extension combinations and single-file scenarios.
tests/test_reader.py Updates existing tests for new extension style and adds comprehensive coverage for only/exclude logic.
src/sqlite_rag/sqliterag.py Passes new filtering parameters through to FileReader.collect_files.
src/sqlite_rag/reader.py Refactors extension list format and implements only/exclude filtering in is_supported and collect_files.
src/sqlite_rag/cli.py Adds CLI options --only / --exclude and parses them into lists.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 98.26590% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sqlite_rag/cli.py 57.14% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielebriggi danielebriggi merged commit 01a860c into main Oct 7, 2025
5 checks passed
@danielebriggi danielebriggi deleted the 8-include-exclude-file-type branch October 7, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants