Make URL and POST parameters immutable#1109
Merged
Conversation
- URL and POST parameters are now immutable after request initialization
- SET command creates user-defined variables in separate namespace
- Variable lookup: SET variables shadow request parameters
- Added sqlpage.variables('set') to inspect user-defined variables
- Simplified API: most functions now use &RequestInfo instead of &mut
- All tests passing (151 total)
173283c to
d69b1d1
Compare
- Warn when both URL and POST have same variable name - Warn when $var is used for POST-only variable (should use :var)
No need to branch on whether variables are provided since we clone in both cases anyway.
This reverts commit 60f5a05.
6 tasks
Renamed test to run only on SQLite since json_extract() is SQLite-specific. Other databases (PostgreSQL, MySQL, MSSQL) have different JSON functions.
PostgreSQL doesn't have json_extract, so compare the full JSON string instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
URL parameters and form data could be overwritten by SET statements, making it impossible to access original request values after modification.
Solution
Request parameters (URL and POST) are now immutable. SET creates user-defined variables in a separate namespace that shadow request parameters during lookup.
Changes
Data Structure:
Variable Lookup:
API Simplification:
New Functionality:
Documentation:
Tests:
Breaking Changes
None. Existing code continues to work with identical behavior.