Add set variable function and update docs#1124
Merged
Conversation
Co-authored-by: contact <contact@ophir.dev>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: contact <contact@ophir.dev>
…docs-gemini-3-pro-preview-7df1
- Replaced serde_json::Map with a custom URLParameters struct for better management of URL parameters. - Introduced methods for handling single and vector values in URLParameters. - Updated tests to reflect changes in the set_variable function's behavior.
- Renamed URLParameters module for clarity and removed the deprecated url_parameter_deserializer. - Updated the set_variable function to return parameters directly instead of appending to a URL. - Adjusted related function calls to reflect changes in URL parameter management.
lovasoa
deleted the
cursor/add-set-variable-function-and-update-docs-gemini-3-pro-preview-7df1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sqlpage.set_variablefunction for easily modifying URL parameters on the current page while preserving others.This new function simplifies the common pattern of updating a single URL parameter without losing other existing parameters, which previously required a more verbose
sqlpage.link(sqlpage.path(), json_patch(sqlpage.variables('get'), json_object(name, value)))construct.