Merged
Conversation
- Simplified SQL test files by removing unnecessary components and restructuring queries to focus on expected vs actual results. - Updated the request handling in `run_sql_test` to differentiate between JSON and HTML responses based on test file content. - Enhanced error handling and assertions for both JSON and HTML responses to improve test reliability and clarity. - Removed redundant code and improved readability in the test execution flow.
- Changed references in various test files to point to the new `simple.sql` instead of the outdated `it_works_simple.sql`. - Removed several obsolete SQL test files that are no longer needed, streamlining the test suite. - Updated assertions and request paths in the test cases to reflect the new structure and improve clarity.
lovasoa
force-pushed
the
simplify-tests
branch
from
3713c98 to
a102ae1
Compare
- Added a new function `format_error` to improve error reporting in SQL test assertions, capturing detailed error descriptions and backtraces. - Updated SQL syntax in `sqrt.sql` to use `INT` instead of `integer` for consistency with SQL standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_sql_testto differentiate between JSON and HTML responses based on test file content.