Merged
Conversation
|
Cursor Agent can help with this pull request. Just |
lovasoa
force-pushed
the
cursor/oidc-logout-redirect-uri-cb05
branch
from
72427de to
d4f1671
Compare
This commit refactors the OIDC tests to use a more robust fake OIDC provider and improves the logout URL generation to correctly handle the scheme. Fixes #1174
lovasoa
force-pushed
the
cursor/oidc-logout-redirect-uri-cb05
branch
from
d4f1671 to
629087b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OIDC logout redirect URI to use the configured application scheme, resolving incorrect redirects behind proxies.
Previously, the
post_logout_redirect_uriwas constructed using the scheme of the incoming request, which could be HTTP even if the application was configured for HTTPS (e.g., when behind a TLS-terminating proxy). This led to the OIDC provider redirecting back to an insecure HTTP URL after logout, causing issues like those described in #1174. This change ensures thepost_logout_redirect_uriis derived from the OIDC client's configured redirect URL, maintaining the correct scheme and host. A new test casetest_oidc_logout_uses_correct_schemehas been added to verify this behavior.