Merged
Conversation
This change ensures that when `site_prefix` is configured, the OIDC redirect URI and logout URI include this prefix. Previously, `site_prefix` was ignored, causing OIDC callbacks to fail when the application was served under a sub-path. - Added `site_prefix` to `OidcConfig`. - Updated `make_oidc_client` to prepend `site_prefix` to the redirect URI. - Updated `handle_request` to match paths with `site_prefix` included. - Updated `validate_redirect_url` to respect the prefix when verifying redirect targets. - Added a regression test `test_oidc_with_site_prefix`.
|
Cursor Agent can help with this pull request. Just |
This commit updates several dependencies to their latest versions and removes unused crates to streamline the project. Co-authored-by: contact <contact@ophir.dev>
lovasoa
force-pushed
the
cursor/oidc-site-prefix-handling-ae1f
branch
from
8b0b397 to
3aa95a4
Compare
lovasoa
force-pushed
the
cursor/oidc-site-prefix-handling-ae1f
branch
from
4a6c1d6 to
3de7584
Compare
Contributor
|
Hello. I'm using version 0.42.0 behind reverse proxy with oidc and site prefix. |
Collaborator
Author
|
Hi @billy34 ! You are right, I created a new issue to track your suggestion. Are you interested in contributing? |
Contributor
|
Sorry I have enough knowledge to assess that the code does not use site prefix for this case but I have absolutely no knowledge of rust. I maybe can propose some code but have no way to compile or test it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OIDC to correctly handle
SITE_PREFIXin redirect URLs and path validation, resolving issues when SQLPage is hosted under a subpath.