Added an option to format numbers using toLocaleString() for table columns#807
Merged
lovasoa merged 2 commits intosqlpage:mainfrom Feb 11, 2025
Merged
Added an option to format numbers using toLocaleString() for table columns#807lovasoa merged 2 commits intosqlpage:mainfrom
toLocaleString() for table columns#807lovasoa merged 2 commits intosqlpage:mainfrom
Conversation
Collaborator
|
Thank you very much for this contribution ! I'll take things from here. The results look good, I think I'll revert the logic to be opt out rather than opt in (format numbers by default). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #802
This is the best I could hack, with my limited knowledge and in the time I had to spare. The basic usage is as follows:
E.G: if you need a table with two columns with numbers formatted using exactly three decimals, and a markdown column with links, you would write
Pros:
Cons:
toLocaleString()can do so much more, and the list of available options is very very long. I am not sure if we should just allow the user to pass in a JSON structure so that he can choose whatever combination is needed (e.g: this can include formatting with a given currency!)number_format_digitsfield, I have not tested to see what happens if a user inputs anything other than an integerLet me know what you think about this!