Add link & target props to big_number.handlebars#861
Conversation
|
Thanks Hansky ! As I said in #859 , I think target=_blank is not the most user friendly for people who are not already familiar with html. Maybe By the way, do you work with @accforgithubtest ? |
lovasoa
left a comment
There was a problem hiding this comment.
Could you also document the changes and add an example for them in https://github.com/sqlpage/SQLPage/blob/main/examples/official-site/sqlpage/migrations/49_big_number.sql ?
| {{#if title}} | ||
| <div class="d-flex align-items-center"> | ||
| <div class="subheader text-truncate me-2">{{title}}</div> | ||
| <!-- Otsikko (title): mahdollisuus linkkiin ja targetiin --> |
There was a problem hiding this comment.
Could we translate the comments to english and use handlebars comments ?
No, I don't work @accforgithubtest and didn't read that discussion beforehand. I did do some modifications regarding that title_link_new_tab and modified 49_big_number.sql. |
lovasoa
left a comment
There was a problem hiding this comment.
Can you update the changelog and the documentation too ?
Well, then you both had the same idea at almost the same time :) You'll make someone happy ! |
|
Hi @hanskihyv ! I'm sorry for the long delay. I made the last few changes I needed to this pr and merged it. Thank you again for your contribution ! This will be in v0.35 |
We needed link functionality for the Big Number component
This PR introduces support for adding links to both the title and the value fields in the Big Number component. It also allows specifying whether those links should open in the same tab (_self) or a new tab (_blank). The goal is to enable more interactive dashboards where users can navigate between pages directly by clicking on a Big Number’s text.
Usage
Added four optional properties: