Add active indicator to the shell nav items#908
Merged
lovasoa merged 4 commits intosqlpage:mainfrom May 6, 2025
andrewsinnovations:main
Merged
Add active indicator to the shell nav items#908lovasoa merged 4 commits intosqlpage:mainfrom andrewsinnovations:main
lovasoa merged 4 commits intosqlpage:mainfrom
andrewsinnovations:main
Conversation
lovasoa
requested changes
May 3, 2025
Collaborator
lovasoa
left a comment
There was a problem hiding this comment.
Cool, thank you !
can you document it and add an example in https://github.com/sqlpage/SQLPage/blob/main/examples/official-site/sqlpage/migrations/01_documentation.sql#L1160-L1386 ?
Contributor
Author
|
Done! Updated example 1 to mark one page as active in the documentation and added some text to reflect that. |
Collaborator
|
Example 1 is the menu that is actually used in the official website. This change would mark the "About" menu as active on all pages ! |
Contributor
Author
|
I pulled out the active flag example into its own example with a description of the SQL. Let me know if that is better! |
lovasoa
reviewed
May 6, 2025
lovasoa
approved these changes
May 6, 2025
Collaborator
|
Thank you @andrewsinnovations ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to have SQL that indicates that a navigation bar should be shown as "active" in the shell.
Also works in the sidebar: