Merged
Conversation
lovasoa
approved these changes
Jun 5, 2025
Collaborator
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
I added tests and fixed a bug with decoding large values. When the tests pass, we can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MSSQL, the MONEY and SMALLMONEY types are specialized variants of DECIMAL with fixed decimal precision:
MONEY is equivalent to DECIMAL(19,4) (19 total digits with 4 decimal places)
SMALLMONEY corresponds to DECIMAL(10,4) (10 total digits with 4 decimal places)
When mapping these to Rust, the most suitable data types are rust_decimal or bigdecimal to preserve exact precision without floating-point errors.
In financial software development, the MONEY data type is widely used. Therefore, we strongly recommend adding support for the MONEY type in sqlx-oldapi.
This PR extracts shared codes into decimal_tools.rs included with testing code.