keep Google Chat Linux as window title#96
keep Google Chat Linux as window title#96AlessioCoser wants to merge 1 commit intosqualou:masterfrom
Conversation
|
Honestly, having a static title has no interest, not sure why you would want that. On the other hand, default behavior sets title to current conversation, which is probably not a killer feature but is not bad. Is there a reason I don't get to explicitely leave the title static ? |
|
Yep, the reason is the title provided by the google chat website is only "chat". I found it a bit confusing... but I agree, it's a minimal thing. I've done on my fork and wanted to share to contribute and to know your opinion |
|
Interesting, I probably didn't understand the first intent. I mean, maybe the behavior I see is not the same as what you see. I get the same thing as the app title. That's what I said didn't hurt. Don't you get the same result ? |
|
I mean, having just 'Chat' as the window title is too generic. Which chat is it? I can't tell from the title alone. This was the main reason that led me to hardcode the title. I thought that since the app's name is fixed as 'Google Chat Linux', its window title should be the same regardless of the page title. |
|
That's weird, With your change, the title would always stay static, right ? I guess it would need an optional toggle to be perfect. |
|
Yeah, it's strange. Do you mean we could add a configuration flag? I definitely could do this. Something like static-app-title defaulted to false? |
|
Yes, that's exactly the idea. Would be great. (and adding a quick word about it in the README, even if it's already a mess to read :) I should clean it up one of these days) |
Do not update the window title based on the webpage