Add support for secondly, minutely, and hourly frequencies #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, LGTM! Looks like tests are failing because our workflow action versions are out of date - I updated them in master, mind rebasing on current master so they'll (hopefully) pass? |
ghost
approved these changes
Mar 6, 2025
ghost
merged commit
Contributor
Author
|
@rmitchell-sq Thanks for the quick review and merge! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the missing frequency types for secondly, minutely, and hourly recurrences.
I'm pretty new to the recurrence rule spec and this gem, so there might be use cases missing that I currently don't see.
I'm not super happy with the way timesets are handled in the newly added frequencies, very open to feedback and ideas on those.