Conversation
Benchmark results
|
arj03
approved these changes
Jul 12, 2021
arj03
left a comment
Member
There was a problem hiding this comment.
I was looking at the old file and the new and this does seem to improve readability overall. This will probably mean I need to rebase some PRs but that is okay, I want to rebase them on top of validate2 PR anyway.
Member
Author
|
@arj03 if you want, I can do this refactor after the big merges happen. |
Member
|
Might be a good way to review it :) |
staltz
marked this pull request as draft
July 13, 2021 08:15
Member
Author
|
I'll park this PR for now, I can copy-paste or reuse parts of it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two main changes here:
await new Promise((resolve) =>