Skip to content

Add a touched-code cleanup guardrail#76

Merged
ssheld merged 1 commit intomainfrom
issue-56-scope-guardrail
Mar 17, 2026
Merged

Add a touched-code cleanup guardrail#76
ssheld merged 1 commit intomainfrom
issue-56-scope-guardrail

Conversation

@ssheld
Copy link
Copy Markdown
Owner

@ssheld ssheld commented Mar 17, 2026

Summary

Files Changed

  • scaffold/agent-vault/shared-rules.md: add the new Core Principles guardrail
  • scaffold/agent-vault/AGENTS.md: mirror the shared-rules change

Validation

  • bash scripts/check-policy-mirrors.sh
  • git diff --check

Risks

  • Low risk; this is workflow-policy only and affects future agent behavior, not scripts or generated file structure.

Docs Consistency

  • No README.md or docs/design.md changes needed.

Notes

Refs #56

Copy link
Copy Markdown
Owner Author

@ssheld ssheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Review by Claude Opus 4.6 · via Claude Code
Formal review state unavailable: cannot approve own pull request

No findings above the confidence threshold.

One line, exactly where we agreed it should go (Core Principles, after the planning guardrail), identically mirrored. This matches the #56 consensus plan — PR 1 of 2.

The wording is well-calibrated. "Do not widen scope into unrelated cleanup unless it was explicitly requested or is necessary for correctness or maintainability of the current change" gives two clear exception paths (user asked for it, or it's needed for the change to be correct/maintainable) without leaving room for "this nearby code could use some cleanup" drift.

Placement as the last bullet in Core Principles is correct — it's a scope discipline rule that applies across all work, not specific to any one workflow phase.

Strengths

  • Minimal, focused change that delivers the highest-value import from #56.
  • The two exception paths ("explicitly requested" and "necessary for correctness or maintainability") prevent the guardrail from being too rigid while still closing the opportunistic-cleanup loophole.

Merge Recommendation

Approve

Top Risks

  • None.

Suggested Additional Tests

  • None beyond the mirror check already run.

@ssheld ssheld merged commit a5ed7c9 into main Mar 17, 2026
2 checks passed
@ssheld ssheld deleted the issue-56-scope-guardrail branch March 17, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant