Remove direct accesses to CustomData#2288
Remove direct accesses to CustomData#2288bwhitchurch wants to merge 3 commits intosstsimulator:develfrom
Conversation
bwhitchurch
force-pushed
the
new-feature
branch
from
adb0cb7 to
99b03bd
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
bwhitchurch
force-pushed
the
new-feature
branch
from
99b03bd to
eaf9ecb
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
There was a problem hiding this comment.
std::exchange is C++14 feature used by CustomResp/Req::set/releaseData(). I'm not sure how long ago PinCRT started supporting new features, but it seems C++17 is on the table since at least 3.26
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
3 participants
This is related to sstsimulator/sst-core#1001. This patch depends on the interface introduced by sstsimulator/sst-core#1021.