[draft-js-export-markdown] Support code fence#159
Merged
Conversation
3 tasks
e8ceec5 to
b600623
Compare
mxstbr
approved these changes
Jan 12, 2019
Collaborator
mxstbr
left a comment
There was a problem hiding this comment.
Maybe calling the option gfm: true as it is called in draft-js-import-markdown would make sense? Other than that, this looks perfect!
Owner
Author
|
OK, done. I've made that change. The reason for calling it codeFence is because I'm not sure what other GFM features there are and which ones we might want to support in the future and if we'd want to give them separate options (meaning if you're using That being said, I'm going to land this with your suggestion and yolo 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for an option to export Github-style fenced code blocks.
You can pass a second (optional) argument like so:
The only option currently supported is:
The test-cases.txt file as been updated to allow passing options after the description (separated by a "|").
This PR addresses withspectrum/spectrum#4472.