Fix native Windows synchronized cursor placement#4753
Open
Jinwoo-H wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — rewrites the cursor-show/cursor-position tail of synchronized-output frames on native Windows so the cursor is placed before it is shown, eliminating a flicker at the old cell.
findCursorPositionSequenceEnd— extracts the end index of the nextCUP/CHA/HVPescape (H,G,f) after a given offset, matching the existing cursor-position-recognition pattern incontainsCursorPositionSequence.- Rewrite in
removeTransientCursorShowSequences— when a cursor-show has no subsequent hide but is followed by a cursor-position before data end, the position is sliced before the show. The comment captures the "why" cleanly. containsFinalCursorPlacementBeforeSynchronizedEnd— within a synchronized frame, detects whether the final show is followed by a position before the end marker. Feeds intocoalescedQueuedDataNeedsCursorRestoreto skip the fallback cursor-restore pass when the inline rewrite already handles it.- Regression test — covers the
show → position → sync-endpattern; asserts a single drain call (no fallback wait) and the reordered bytes.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/lib/pane-manager/pane-terminal-output-scheduler.test.tspnpm exec vitest run --config config/vitest.config.ts src/renderer/src/lib/pane-manager/pane-terminal-output-scheduler.test.ts src/renderer/src/components/terminal-pane/pty-connection.test.tspnpm exec oxlint src/renderer/src/lib/pane-manager/pane-terminal-output-scheduler.ts src/renderer/src/lib/pane-manager/pane-terminal-output-scheduler.test.ts --quietpnpm run typecheck:webpnpm run build:electron-vitepnpm run test:e2e:terminal-perfNotes
Orca.exe; no packaged validation is claimed from that attempt.