chore: Vendor the UI into this repository#873
Open
lfrancke wants to merge 915 commits into
Open
Conversation
minor cleanup and edits
resolves #177 add spacing between paragraphs in default table cell
- indent content of details element - fix top margin of content - use custom marker to get consistent appearance and behavior - fully style details element with result role - change cursor for summary element to pointer - prevent WebKit from highlighting text of summary element when activated
resolves #178 adjust styles for details element
…ment when activated in Safari
resolves #64 add support for frame and grid styles on tables
…r each frame and grid permutation
- apply max-width, height, display, and vertical-align properties to object[type="image/svg+xml"] selector - apply fallback width to object[type="image/svg+xml"] selector when width is not specified (only works in Chrome)
…ide image block or phrase
- ignore nowrap on pre element
Version updates, Github workflow, footer etc.
Co-authored-by: Felix Hennig <felix.hennig@stackable.tech> Co-authored-by: Lars Francke <git@lars-francke.de>
Add OpenSearch
…-search Add keyboard navigation to search
fix: cleanup header structure
fix: separate loading of mermaid scripts
feat: disable cookies and remove consent cookie banner
chore: Update footer
feat: Add universal navigation bar
…according to CD (#150)
The UI is vendored into this repository in the following commit.
Imported with 'git subtree add' from https://github.com/stackabletech/documentation-ui.git (branch stackable), full history preserved. UI changes are now normal PRs in this repository and show up in deploy previews without a submodule bump. git-subtree-dir: ui git-subtree-mainline: 080032c git-subtree-split: ba3a4d5
- ui/UPSTREAM records how to diff against antora-ui-default; the first reviewed SHA is established by the upcoming upstream re-sync. - netlify-fetch no longer switches branches: it creates/updates the local release branches and materializes their blobs via pathspec checkouts (ui/ excluded - release branches still reference it as a submodule and its blobs are not needed). - The UI lint/bundle CI moves to .github/workflows/ui.yml, filtered on ui/** (workflows in ui/.github never triggered from a subdirectory). - The Antora build extensions move from supplemental-ui/lib/ to lib/: supplemental-ui is the UI file overlay and everything in it is published to the site, which build extensions should not be. - @antora/lunr-extension is removed: search is Pagefind, nothing references the extension.
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Felix Hennig seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The UI files never went through this repository's pre-commit hooks.
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UI moves from the documentation-ui submodule into
ui/in this repository.When I started this documentation project I just forked the upstream Antora UI and that followed this model. That also made it easy to sync with upstream.
But it's been super annoying to have to do two commits (one in documentation-ui and one in documentation) for each design change. So I decided to vendor it in. Any UI changes are now just one PR 🥳
git subtree addsupplemental-ui/lib/→lib/: supplemental-ui is the UI file overlay, so the extensions were being published to the live site (/_/lib/*.js). They aren't anymore..github/workflows/ui.yml, path-filtered onui/**(the workflow insideui/.github/could never trigger from a subdirectory).@antora/lunr-extensionremoved: dead dependency, search is Pagefind.Verification
<lastmod>timestamps, the intentionally updated sentence on the contributor project-overview page, and the extensions no longer appearing in the published output.netlify-fetchtested against a genuine blobless clone (--filter=blob:none, like Netlify's): local release branches created, all release tip trees fully materialized (verified with a non-lazy-fetching check), working tree clean and HEAD untouched afterwards.npm run bundle --workspace uiworks from the repo root (used by the new CI workflow).Follow-up after merge
Archive the documentation-ui repository with a README pointer
Reviewer's guide
This PR looks huge, but it's not!
uisubdirectory. It's just copied inlibas that is also just a moving around thingBasically you can look at the playbooks, makefile, README, ...and that's it