chore!: Upgrade to schemars 1.0, kube 2.0 and k8s-openapi 0.26#1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/kube-rs/kube/releases/tag/2.0.0
https://graham.cool/schemars/migrating/
During the bump I noticed a regression in kube 2.0.0 and created kube-rs/kube#1821.
However, we can easily work around this but removing a single rustdoc comment, which didn't show up in the CRD in the first place. It's in
crates/stackable-operator/src/product_logging/spec.rs.I tested this change by bumping op-rs in zookeeper-operator and smoke tests passed.
Definition of Done Checklist
Author
Reviewer
Acceptance