Skip to content

chore!: Use serde_json::Value instead of String for user-provided JSON configOverrides#1206

Merged
sbernauer merged 4 commits into
mainfrom
chore/json-config-overrides
May 8, 2026
Merged

chore!: Use serde_json::Value instead of String for user-provided JSON configOverrides#1206
sbernauer merged 4 commits into
mainfrom
chore/json-config-overrides

Conversation

@sbernauer

@sbernauer sbernauer commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Feedback from stackabletech/opensearch-operator#137

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this May 7, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 7, 2026
@sbernauer sbernauer mentioned this pull request May 7, 2026
Merged
18 tasks
@dervoeti dervoeti self-requested a review May 7, 2026 17:42
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 7, 2026
dervoeti
dervoeti previously approved these changes May 7, 2026
View reviewed changes

@dervoeti dervoeti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread crates/stackable-operator/CHANGELOG.md Outdated
@sbernauer @dervoeti
Update crates/stackable-operator/CHANGELOG.md
d8d099b 
Co-authored-by: Lukas Krug <lukas@luvosys.de>
sbernauer
sbernauer commented May 8, 2026
View reviewed changes
Comment thread crates/stackable-operator/CHANGELOG.md Outdated
@sbernauer sbernauer requested a review from dervoeti May 8, 2026 07:01
@sbernauer sbernauer enabled auto-merge May 8, 2026 07:07
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 8, 2026
@sbernauer sbernauer disabled auto-merge May 8, 2026 07:12
@sbernauer sbernauer moved this from Development: Done to Development: In Review in Stackable Engineering May 8, 2026
@sbernauer sbernauer added this pull request to the merge queue May 8, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 8, 2026
Merged via the queue into main with commit 57d8d12 May 8, 2026
5 checks passed
@sbernauer sbernauer deleted the chore/json-config-overrides branch May 8, 2026 07:18
@sbernauer sbernauer mentioned this pull request May 8, 2026
Merged
20 tasks
@siegfriedweber siegfriedweber mentioned this pull request Jun 22, 2026
Merged
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dervoeti dervoeti dervoeti approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @dervoeti @lfrancke