feat: fallback to non-compact when a package fails to use compact mode#450
feat: fallback to non-compact when a package fails to use compact mode#450
Conversation
|
I'd like to know your thought about this, @aprendendofelipe. Thanks! |
commit: |
aprendendofelipe
left a comment
There was a problem hiding this comment.
Looks great! 🚀
Later on, we could consider a per-package fallback, possibly via an sb-compact-packages API header.
@aprendendofelipe As discussed internally, the npm is just for a feature ( --compact ) to check if we can make the url smaller, it's not for verification. |
|
This only affects the PR comment, correct? I think it makes sense to make the compact URL the default, as long as there is still a way to opt into the long form. |
related to #402