Skip to content

feat: fallback to non-compact when a package fails to use compact mode#450

Open
AmirSa12 wants to merge 2 commits intomainfrom
feat/non-compact-fallback
Open

feat: fallback to non-compact when a package fails to use compact mode#450
AmirSa12 wants to merge 2 commits intomainfrom
feat/non-compact-fallback

Conversation

@AmirSa12
Copy link
Member

@AmirSa12 AmirSa12 commented Feb 1, 2026

related to #402

@AmirSa12
Copy link
Member Author

AmirSa12 commented Feb 1, 2026

I'd like to know your thought about this, @aprendendofelipe. Thanks!

@continuous-releases-staging
Copy link

  • example-1

  • example-2

    npm i https://855c9e6b.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-a@450
    
    npm i https://855c9e6b.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-b@450
    
    npm i https://855c9e6b.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@450
    

commit: a62fb61

Copy link
Contributor

@aprendendofelipe aprendendofelipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Later on, we could consider a per-package fallback, possibly via an sb-compact-packages API header.

@AmirSa12
Copy link
Member Author

AmirSa12 commented Feb 2, 2026

Looks great! 🚀

Later on, we could consider a per-package fallback, possibly via an sb-compact-packages API header.

@aprendendofelipe As discussed internally, the npm is just for a feature ( --compact ) to check if we can make the url smaller, it's not for verification.
What do you think about making --compact obsolete by making that the default behavior, and if it fails, we just continue going with the long form? let me know your thoughts! Thanks

@aprendendofelipe
Copy link
Contributor

This only affects the PR comment, correct?

I think it makes sense to make the compact URL the default, as long as there is still a way to opt into the long form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants