Skip to content

Fix appliances_extra_packages_default missing stackhpc fatimage #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjpb merged 3 commits into from
Dec 10, 2025
Merged

Fix appliances_extra_packages_default missing stackhpc fatimage #856

sjpb merged 3 commits into from
Dec 10, 2025
+9 −7

Conversation

@elelaysh
Copy link
Contributor

@elelaysh elelaysh commented Dec 1, 2025

  • put fatimage in the extra_packages group so that they get installed
  • small doc fix

@elelaysh elelaysh requested a review from a team as a code owner December 1, 2025 10:40
@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 1, 2025 •
edited
Loading

Successful image build on SMS lab: RL9 and RL8

htop, etc. are installed during the packer build.

@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 4, 2025 •
edited
Loading

Successful fatimage builds RL8 and RL9 on leafcloud

@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch from 9e32df8 to f4f5de7 Compare December 4, 2025 12:33
@elelaysh elelaysh self-assigned this Dec 4, 2025
@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch 2 times, most recently from d663945 to 0a5a45a Compare December 9, 2025 12:48
@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 9, 2025

fatimage rebuilt on leafcloud: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20060839207

sjpb
sjpb requested changes Dec 10, 2025
View reviewed changes
@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch from 0a5a45a to bf758a6 Compare December 10, 2025 09:01
sjpb
sjpb requested changes Dec 10, 2025
View reviewed changes
@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch from bf758a6 to 6d77c2c Compare December 10, 2025 09:32
@sjpb sjpb self-requested a review December 10, 2025 10:00
sjpb
sjpb requested changes Dec 10, 2025
View reviewed changes
@elelaysh
fix extra_packages not in released fatimages
3577260 
eg htop is not in the 2.7 image openhpc-RL9-250925-1639-62d67ae3.
@elelaysh
doc/image-build.md: rephrase PKR_VAR_environment_root
ece6d77 
because we don't show it anymore
@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch from 6d77c2c to 42a63ca Compare December 10, 2025 10:18
@sjpb sjpb self-requested a review December 10, 2025 10:32
@sjpb
Copy link
Collaborator

sjpb commented Dec 10, 2025

Image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20095164635

@elelaysh elelaysh force-pushed the fix/extra_packages-missing-fatimage branch from 42a63ca to 2cbda01 Compare December 10, 2025 10:57
@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 10, 2025

Passed CI with new image

sjpb
sjpb approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 971728b into main Dec 10, 2025
40 of 42 checks passed
@sjpb sjpb deleted the fix/extra_packages-missing-fatimage branch December 10, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjpb sjpb sjpb approved these changes

Assignees

@elelaysh elelaysh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elelaysh @sjpb