-
Notifications
You must be signed in to change notification settings - Fork 23
[draft] RockyLinux 9.7 #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
[draft] RockyLinux 9.7 #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Rocky Linux 9.7 by updating various configuration files. The changes include updating the default Rocky Linux minor version, adding new repository versions for 9.7, and adjusting DOCA version handling. My review focuses on improving maintainability and correcting potential errors in the configuration. I've pointed out a hardcoded branch reference that should be made more generic, a misleading comment, and a likely invalid CVE identifier in the Trivy allowlist.
31bc446 to
5a7be0c
Compare
f0a339a to
dc92233
Compare
add a checkbox to the stackhpc-multinode workflow to use the user's ssh key registered in github instead of always copy-pasting
c32d4cd to
e1a73dc
Compare
no repos causes installation of tmux fail in terraform-kayobe-multinode. This regression was introduced by commit e0d1d6d
WIP