addresses ingest - router rework based on function.length 4d#12
Merged
cblanquera merged 2 commits intostackpress:mainfrom Mar 22, 2025
Merged
addresses ingest - router rework based on function.length 4d#12cblanquera merged 2 commits intostackpress:mainfrom
cblanquera merged 2 commits intostackpress:mainfrom
Conversation
cblanquera
requested changes
Mar 19, 2025
packages/ingest/src/Router.ts
Outdated
| action: RouterActions<R, S, X>, | ||
| priority?: number | ||
| ) { | ||
| ): this { |
Member
There was a problem hiding this comment.
Remove : this. Should be implied.
cblanquera
approved these changes
Mar 22, 2025
Member
cblanquera
left a comment
cblanquera
left a comment
There was a problem hiding this comment.
Looks good. Simple solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
I verify that...
npm run testwith no errors