Skip to content

Chore/6601 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wileyj wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Chore/6601 #91

wileyj wants to merge 20 commits into from

Conversation

@wileyj
Copy link
Contributor

@wileyj wileyj commented Nov 17, 2025 •
edited
Loading

Updates composites to simplify and move towards using artifacts built natively vs binaries built in docker.

  • docker composite adds a registry input to allow for publishing to other registries (default remains docker hub)
  • simplified check of what release type a build is (if a version string is x chars, assume it is one of stacks-core/stacks-signer)
  • standardize artifact name to include sha-type-arch which should simplify artifact usage
  • remove extra tag inputs where appropriate. we have the same data already, no need to send it more than once
  • removed the runner cleanup step that was running as a default when calling the docker composite

wileyj added 19 commits November 7, 2025 22:46
@wileyj
- add registry input to switch image repo
78d48bc 
- remove runner cleanup, not needed for docker builds
@wileyj
docker no-cache and update versions
21c9fdb
@wileyj
updates for release
42aed1a
@wileyj
fix source of the composite
7200889
@wileyj
set artifact pattern based on type
668ff34
@wileyj
fix typo in pattern
7f2c819
@wileyj
only download artifacts for specific relesae
a6fecd7
@wileyj
check for version length and remove input
a72f66f
@wileyj
remove input
77c44ad
@wileyj
fix step with proper syntax
507aff9
@wileyj
testing without repo
d1262f5
@wileyj
reset default docker registry
275454d
@wileyj
Squashed commit of:
8e13a26 
    modified:   docker/action.yml
    modified:   stacks-core/release/create-github-release/action.yml
    modified:   stacks-core/release/create-releases/action.yml
@wileyj
use correct naming for the artifacts
ad4efe6
@wileyj
account for rc chars in the tag name
b44d56c
@wileyj
fixes
92b74d2
@wileyj
fix target composite
aa2093a
@wileyj
update composite to use canonical location
c568512
@wileyj
update docs and cleanup
dc5cf44
@wileyj
Copy link
Contributor Author

wileyj commented Nov 17, 2025

note: there are some linting differences in how many spaces were pushed. will have to enforce that in the future

@wileyj
Copy link
Contributor Author

wileyj commented Nov 18, 2025

stacks-network/stacks-core#6697 requires this to merge

@wileyj wileyj mentioned this pull request Nov 19, 2025
Open
@wileyj wileyj marked this pull request as ready for review November 19, 2025 04:31
@wileyj wileyj requested review from a team and federico-stacks December 3, 2025 01:33
federico-stacks
federico-stacks reviewed Dec 3, 2025
View reviewed changes
@wileyj wileyj mentioned this pull request Dec 3, 2025
Open
jacinta-stacks
jacinta-stacks previously approved these changes Dec 4, 2025
View reviewed changes
wileyj added a commit to wileyj/actions that referenced this pull request Dec 4, 2025
@wileyj
Small change based on pr stacks-network#91 comments for testing
4d3014c
federico-stacks
federico-stacks previously approved these changes Dec 4, 2025
View reviewed changes
@wileyj wileyj dismissed stale reviews from federico-stacks and jacinta-stacks via 5aa50dd December 5, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@federico-stacks federico-stacks federico-stacks approved these changes

@jacinta-stacks jacinta-stacks jacinta-stacks approved these changes

@fabrizio-stacks fabrizio-stacks Awaiting requested review from fabrizio-stacks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wileyj @federico-stacks @jacinta-stacks