Skip to content

test: enable/improve rpc tests#7393

Open
federico-stacks wants to merge 7 commits into
stacks-network:developfrom
federico-stacks:test/enable-rpc-tests
Open

test: enable/improve rpc tests#7393
federico-stacks wants to merge 7 commits into
stacks-network:developfrom
federico-stacks:test/enable-rpc-tests

Conversation

@federico-stacks

@federico-stacks federico-stacks commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

This patch does some work along rpc unit tests:

  • For postblock_proposal tests:
    • Remove ignore tag from some tests to make them run automatically as aprt of unit tests automation
    • Make a stale (ignored) test work again: test_block_proposal_validation_timeout
    • add test coverage for a missing scenario: test_block_proposal_validation_execution_time_expired_blames_tx
    • Removed test entry net::api::tests::postblock_proposal::test_try_make_response from tests-p2p.yml workflow as it is already run as part of our unit tests automation
  • For getmapentry tests:
    • removed 3 commented-out tests
    • improve scenarios coverage in the already existing test case: test_try_make_response

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • For new Clarity features or consensus changes, add property tests (see docs/property-testing.md)
  • Changelog fragment(s) or "no changelog" label added (see changelog.d/README.md)
  • Required documentation changes (e.g., rpc/openapi.yaml for RPC endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@coveralls

coveralls commented Jul 7, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29428937263

Coverage increased (+0.8%) to 86.522%

Details

  • Coverage increased (+0.8%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 11991 coverage regressions across 163 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

11991 previously-covered lines in 163 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/chainstate/burn/db/sortdb.rs 638 90.43%
stackslib/src/chainstate/stacks/db/blocks.rs 528 89.93%
stackslib/src/chainstate/nakamoto/mod.rs 488 84.91%
stackslib/src/config/mod.rs 324 78.53%
stackslib/src/net/relay.rs 324 74.43%
stackslib/src/net/mod.rs 312 78.18%
stackslib/src/chainstate/stacks/index/storage.rs 277 82.41%
clarity/src/vm/database/clarity_db.rs 273 82.02%
stackslib/src/chainstate/stacks/db/transactions.rs 269 97.13%
stackslib/src/chainstate/stacks/miner.rs 266 83.18%

Coverage Stats

Coverage Status
Relevant Lines: 231325
Covered Lines: 200147
Line Coverage: 86.52%
Coverage Strength: 19568062.29 hits per line

💛 - Coveralls

@federico-stacks
federico-stacks marked this pull request as ready for review July 8, 2026 09:35
@federico-stacks
federico-stacks requested review from francesco-stacks, rob-stacks and simone-stacks and removed request for simone-stacks July 8, 2026 09:35
rob-stacks
rob-stacks previously approved these changes Jul 13, 2026

@rob-stacks rob-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@federico-stacks
federico-stacks added this pull request to the merge queue Jul 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 15, 2026
@federico-stacks

Copy link
Copy Markdown
Contributor Author

I had to update to latest merge to avoid a conflict materialized on the merge queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants