Reject duplicate basic auth usernames within a server#60
Merged
Conversation
The middleware matches basic auth by username and short-circuits on the first hit, so two entries with the same username silently shadowed each other regardless of the `name` field. Reject at config load.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements validation to ensure that basic authentication usernames are unique within a server's service authorizations. Changes include updates to the JSON unmarshaling logic and the validation suite to detect duplicate usernames, along with a new test case to verify this behavior. The review feedback suggests optimizing the performance of the newly added maps by providing size hints during initialization.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The middleware matches basic auth by username and short-circuits on the first hit, so two entries with the same username silently shadowed each other regardless of the
namefield. Reject at config load.