Update VIF codes.#10
Merged
Merged
Conversation
stankudrow
force-pushed
the
update-vif-codes
branch
from
3fa0c42 to
4658977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table/catalogue of main VIF codes is finished, the
get_vif_codefactory function is less linear, but stillO(n)(if I am not mistaken).Maybe the idea with inheritance was misleading and this module may undergo major rearrangement.
UPD: CHANGELOG and other special VIF codes are finalised in the PR #14 (hastiness).